Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate printToPDF margins against pageSize #41267

Merged
merged 1 commit into from Feb 8, 2024
Merged

fix: validate printToPDF margins against pageSize #41267

merged 1 commit into from Feb 8, 2024

Conversation

codebytere
Copy link
Member

Backport of #41157.

See that PR for details.

Notes: Fixes an issue where webContents.printToPDF could fail when certain combinations of margins and pageSize values are passed.

@codebytere codebytere requested a review from a team February 7, 2024 18:04
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 7, 2024
@trop trop bot mentioned this pull request Feb 7, 2024
Merged
4 tasks
@trop trop bot added 28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 7, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 7, 2024
@eezz4
Copy link

eezz4 commented Feb 7, 2024

@codebytere Great to see and learn from! Thank you!

@zcbenz zcbenz merged commit abd7850 into 28-x-y Feb 8, 2024
18 checks passed
@zcbenz zcbenz deleted the validate-margins-28 branch February 8, 2024 02:15
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 8, 2024

Release Notes Persisted

Fixes an issue where webContents.printToPDF could fail when certain combinations of margins and pageSize values are passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @eezz4 @zcbenz