fix: GetCursorScreenpoint() sometimes wrongly returns (0,0)
#41275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
platform/linux
semver/patch
codebytere
approved these changes
Feb 8, 2024
codebytere
changed the title
GetCursorScreenpoint() sometimes wrongly returns (0,0)
|
CI is failing due to known unrelated CI flake #41295 & should be safe to merge |
ckerr
deleted the
fix/41143-get-cursor-screenpoint-wrongly-returns-origin
branch
|
Release Notes Persisted
|
|
I have automatically backported this PR to "29-x-y", please check out #41296 |
trop
bot
added
in-flight/29-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #41143.
The bug was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/5214873 which tests for
x11::Input::CrossingEventbut callsui::EventSystemLocationFromXEvent(), which uses the similarly-named-but-different-classx11::CrossingEvent. This mismatch causesx11::Input::CrossingEvents to incorrectly record the cursor's location at0, 0.https://chromium-review.googlesource.com/c/chromium/src/+/5225569 exposed the 5214873 bug to Electron via
X11ScreenOzone::GetCursorScreenPoint(), which caches the return value ofX11ScreenOzone::GetCursorScreenPoint()to avoid a round trip to X.This patch should be backported to e29 to fix the release blocker + upstreamed to Chromium.
All reviews welcome!
Checklist
npm testpassesRelease Notes
Notes: Fixed Electron 29.0.0-beta.3 regression that could pop up context menus in the wrong location.