Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add capability to use ScreenCaptureKit for thumbnail generation #41329

Commits on Feb 14, 2024

  1. fix: add capability to use ScreenCaptureKit for thumbnail generation

    This aligns us with Chromiums flags / capabilities in regards to using SCK for
    everything. Currently on 14.4 Electron apps will pop warnings for usage of
    deprecated APIs.  With this change and a few "enable-features" toggles.
    
    `--enable-features="ScreenCaptureKitMac,ScreenCaptureKitStreamPickerSonoma,ThumbnailCapturerMac:capture_mode/sc_screenshot_manager"`
    
    As Chromium enables these by default Electron will inherit those changes, apps wishing to skip ahead can apply these flags early.
    
    Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
    trop[bot] and MarshallOfSound committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    60bd757 View commit details
    Browse the repository at this point in the history