fix: properly stream uploadData in protocol.handle()
#41358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Increase readability by moving the file stream creation logic out of the `uploadData` to request body conversion function. Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Refs: #39658 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Refs: #40754 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Refs: #38929 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Refs: #40826 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
4 tasks
trop
bot
added
28-x-y
backport
codebytere
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Type error here:
electron/spec/api-protocol-spec.ts(1654,50): error TS2345: Argument of type 'ReadableStream<Uint8Array>' is not assignable to parameter of type 'Readable | AsyncIterator<any, any, undefined> | ReadableStream'.
Type 'ReadableStream<Uint8Array>' is missing the following properties from type 'ReadableStream': readable, read, setEncoding, pause, and 21 more.
trop
bot
deleted the
trop/28-x-y-bp-fix-properly-stream-uploaddata-in-protocol-handle--1708111781282
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41052
See that PR for details.
Notes: Fix various bugs which could prevent forwarding requests intercepted with protocol.handle().