New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: user-did-{resign|become}-active
events on macOS
#41506
Conversation
Hi @codebytere |
@brondibur unfortunately no - we maintain four release lines at any given time, with the oldest being primarily security-related fixes. I've opened a PR to correct the doc. |
Release Notes Persisted
|
I have automatically backported this PR to "28-x-y", please check out #41526 |
I have automatically backported this PR to "29-x-y", please check out #41527 |
I have automatically backported this PR to "30-x-y", please check out #41528 |
Description of Change
Closes #41497.
Fixes an issue where
user-did-{resign|become}-active
were not emitted properly on macOS.This was happening because per docs the notification object is the shared NSWorkspace instance - we need to add an observer to
[[NSWorkspace sharedWorkspace] notificationCenter]
and not[NSDistributedNotificationCenter defaultCenter]
.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
user-did-{resign|become}-active
were not emitted properly on macOS.