Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serial-port-added should respect filters #41636

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 20, 2024

Backport of #41621

See that PR for details.

Notes: Fixes an issue where the serial-port-added event improperly respected filters set by serial.requestPort()

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere March 20, 2024 14:19
@trop trop bot added 29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 20, 2024
@codebytere codebytere merged commit 07f5075 into 29-x-y Mar 21, 2024
19 of 20 checks passed
@codebytere codebytere deleted the trop/29-x-y-bp-fix-serial-port-added-should-respect-filters-1710944349235 branch March 21, 2024 11:57
Copy link

release-clerk bot commented Mar 21, 2024

Release Notes Persisted

Fixes an issue where the serial-port-added event improperly respected filters set by serial.requestPort()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant