Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't do self-destroy in LibnotifyNotification::Dismiss() #41708

Merged
merged 1 commit into from Mar 28, 2024
Merged

fix: don't do self-destroy in LibnotifyNotification::Dismiss() #41708

merged 1 commit into from Mar 28, 2024

Commits on Mar 27, 2024

  1. fix: don't do self-destroy in LibnotifyNotification::Dismiss() 

    Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()

This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.

Fixes #40461.

Co-authored-by: taoky <me@taoky.moe>
    @trop @taoky
    trop[bot] and taoky committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0ed8eec View commit details
    Browse the repository at this point in the history