New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nativeImage.createThumbnailFromPath
and shell.openExternal
in renderer
#41875
Conversation
Could this PR be ported to version 27.x ? Many of us are still unable to upgrade to 28.x due to this issue: electron-react-boilerplate/electron-react-boilerplate#3568 . Much appreciated! |
@nornagon it was https://chromium-review.googlesource.com/c/chromium/src/+/4369441 i believe! |
nativeImage.createThumbnailFromPath
in renderer
@gaodeng v27 is no longer supported unfortunately: https://www.electronjs.org/docs/latest/tutorial/electron-timelines |
nativeImage.createThumbnailFromPath
in renderernativeImage.createThumbnailFromPath
and shell.openExternal
in renderer
Updated this PR to also fix |
Release Notes Persisted
|
I was unable to backport this PR to "28-x-y" cleanly; |
I was unable to backport this PR to "29-x-y" cleanly; |
I have automatically backported this PR to "31-x-y", please check out #41908 |
I have automatically backported this PR to "30-x-y", please check out #41909 |
Description of Change
nativeImage.createThumbnailFromPath
wasn't resolving when called in therenderer. This started happening in #37701, I think Chromium stopped pumping
the Grand Central Dispatch queue in renderer processes. I haven't figured out
the exact change which caused the regression, but relying on Chromium's own
dispatch queues fixes the issue.
Fixes #41816.
Checklist
npm test
passesRelease Notes
Notes: Fixed nativeImage.createThumbnailFromPath and shell.openExternal not resolving when called in the renderer process.