Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nativeImage.createThumbnailFromPath and shell.openExternal in renderer #41875

Merged
merged 2 commits into from Apr 19, 2024

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 16, 2024

Description of Change

nativeImage.createThumbnailFromPath wasn't resolving when called in the
renderer. This started happening in #37701, I think Chromium stopped pumping
the Grand Central Dispatch queue in renderer processes. I haven't figured out
the exact change which caused the regression, but relying on Chromium's own
dispatch queues fixes the issue.

Fixes #41816.

Checklist

Release Notes

Notes: Fixed nativeImage.createThumbnailFromPath and shell.openExternal not resolving when called in the renderer process.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 16, 2024
@nornagon nornagon added target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. semver/patch backwards-compatible bug fixes labels Apr 16, 2024
@gaodeng
Copy link

gaodeng commented Apr 17, 2024

Could this PR be ported to version 27.x ? Many of us are still unable to upgrade to 28.x due to this issue: electron-react-boilerplate/electron-react-boilerplate#3568 . Much appreciated!

@codebytere
Copy link
Member

codebytere commented Apr 17, 2024

@nornagon it was https://chromium-review.googlesource.com/c/chromium/src/+/4369441 i believe!

@codebytere codebytere changed the title fix: nativeImage.createThumbnailFromPath in renderer fix: nativeImage.createThumbnailFromPath in renderer Apr 17, 2024
@nornagon
Copy link
Member Author

@gaodeng v27 is no longer supported unfortunately: https://www.electronjs.org/docs/latest/tutorial/electron-timelines

@github-actions github-actions bot added the target/31-x-y PR should also be added to the "31-x-y" branch. label Apr 17, 2024
@nornagon nornagon changed the title fix: nativeImage.createThumbnailFromPath in renderer fix: nativeImage.createThumbnailFromPath and shell.openExternal in renderer Apr 17, 2024
@nornagon
Copy link
Member Author

Updated this PR to also fix shell.openExternal, which was failing for the same reason.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 17, 2024
@jkleinsc jkleinsc merged commit ed9fec7 into main Apr 19, 2024
20 checks passed
@jkleinsc jkleinsc deleted the fix-thumbnail-in-renderer branch April 19, 2024 13:43
Copy link

release-clerk bot commented Apr 19, 2024

Release Notes Persisted

Fixed nativeImage.createThumbnailFromPath and shell.openExternal not resolving when called in the renderer process.

@trop
Copy link
Contributor

trop bot commented Apr 19, 2024

I was unable to backport this PR to "28-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 19, 2024

I was unable to backport this PR to "29-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 19, 2024

I have automatically backported this PR to "31-x-y", please check out #41908

@trop
Copy link
Contributor

trop bot commented Apr 19, 2024

I have automatically backported this PR to "30-x-y", please check out #41909

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/31-x-y PR should also be added to the "31-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/30-x-y in-flight/31-x-y labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. needs-manual-bp/28-x-y needs-manual-bp/29-x-y semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nativeImage.createThumbnailFromPath fails to resolve in renderer process from version 25.0.0
4 participants