Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CHECK when adding view as its own child #42067

Merged
merged 1 commit into from
May 9, 2024
Merged

fix: CHECK when adding view as its own child #42067

merged 1 commit into from
May 9, 2024
+19 −1

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 7, 2024 •
edited

Description of Change

Fixes the following CHECK in View::AddChildViewAtImpl:

[23853:0507/174950.101294:FATAL:view.cc(3081)] Check failed: view != this (0x130006c2000 vs. 0x130006c2000)You cannot add a view as its own child

and adds a test. Incidental to investigation of #41974

Checklist

Release Notes

Notes: Fixes a crash in addChildView if a view is added as its own child.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. labels May 7, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 7, 2024
@codebytere codebytere added target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. labels May 8, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 8, 2024
@jkleinsc jkleinsc merged commit 6675f3a into main May 9, 2024
30 checks passed
@jkleinsc jkleinsc deleted the prevent-view-own-child branch May 9, 2024 13:47
@release-clerk Release Clerk
Copy link

release-clerk bot commented May 9, 2024

Release Notes Persisted

Fixes a crash in addChildView if a view is added as its own child.

This was referenced May 9, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 9, 2024

I have automatically backported this PR to "30-x-y", please check out #42107

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels May 9, 2024
@trop
Copy link
Contributor

trop bot commented May 9, 2024

I have automatically backported this PR to "31-x-y", please check out #42108

@trop trop bot added in-flight/31-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/31-x-y PR should also be added to the "31-x-y" branch. in-flight/30-x-y in-flight/31-x-y labels May 9, 2024
Mrnikifabio pushed a commit to Mrnikifabio/electron that referenced this pull request May 14, 2024
@codebytere @Mrnikifabio
fix: CHECK when adding view as its own child (electron#42067)
d936907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc