Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use //ui/shell_dialogs on Linux #42109

Merged
merged 12 commits into from
May 10, 2024
Merged

refactor: use //ui/shell_dialogs on Linux #42109

merged 12 commits into from
May 10, 2024

Commits on May 9, 2024

  1. refactor: use //ui/shell_dialogs on Linux 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e14eac2 View commit details
    Browse the repository at this point in the history

  2. fix: add proper filtering 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    89c847a View commit details
    Browse the repository at this point in the history

  3. fix: add support for missing dialog features to //shell_dialogs 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e7ebda0 View commit details
    Browse the repository at this point in the history

  4. fix: parent_window could be null 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d906b6d View commit details
    Browse the repository at this point in the history

  5. chore: cleanup patch 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    81be3b8 View commit details
    Browse the repository at this point in the history

  6. fix: use a OnceCallback in the sync implementation 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c5a2699 View commit details
    Browse the repository at this point in the history

  7. chore: remove stray debuglog 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    dd38cbd View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Charles Kerr <charles@charleskerr.com>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fd9f025 View commit details
    Browse the repository at this point in the history

  9. refactor: use settings struct 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    094353e View commit details
    Browse the repository at this point in the history

  10. fix: show hidden file property checking 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b5e0d1f View commit details
    Browse the repository at this point in the history

  11. chore: changes from review 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    41635d6 View commit details
    Browse the repository at this point in the history

  12. fix: multi selection for dialogs 

    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @trop @codebytere
    trop[bot] and codebytere committed May 9, 2024
    Configuration menu
    Copy the full SHA
    aafc537 View commit details
    Browse the repository at this point in the history