-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix cast in ElectronDesktopWindowTreeHostLinux #42179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frame view of the widget is an `ClientFrameViewLinux` instance only when both `frame` and `client_frame` booleans are set to `true`. Otherwise it is an instance of a different class and thus casting to `ClientFrameViewLinux` is incorrect and leads to crashes. Fix: electron#41839
VerteDinde
added
target/30-x-y
PR should also be added to the "30-x-y" branch.
target/31-x-y
PR should also be added to the "31-x-y" branch.
semver/patch
backwards-compatible bug fixes
labels
May 14, 2024
VerteDinde
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you so much for this fix!
VerteDinde
added
the
fast-track 🚅
Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
label
May 14, 2024
VerteDinde
changed the title
Fix cast in ElectronDesktopWindowTreeHostLinux
fix fix cast in ElectronDesktopWindowTreeHostLinux
May 14, 2024
VerteDinde
changed the title
fix fix cast in ElectronDesktopWindowTreeHostLinux
fix: fix cast in ElectronDesktopWindowTreeHostLinux
May 14, 2024
Release Notes Persisted
|
This was referenced May 14, 2024
I have automatically backported this PR to "31-x-y", please check out #42184 |
trop
bot
added
in-flight/31-x-y
and removed
target/31-x-y
PR should also be added to the "31-x-y" branch.
labels
May 14, 2024
I have automatically backported this PR to "30-x-y", please check out #42185 |
trop
bot
added
in-flight/30-x-y
merged/30-x-y
PR was merged to the "30-x-y" branch.
and removed
target/30-x-y
PR should also be added to the "30-x-y" branch.
in-flight/30-x-y
labels
May 14, 2024
trop
bot
added
merged/31-x-y
PR was merged to the "31-x-y" branch.
and removed
in-flight/31-x-y
labels
May 15, 2024
mnvr
added a commit
to ente-io/ente
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track 🚅
Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
merged/30-x-y
PR was merged to the "30-x-y" branch.
merged/31-x-y
PR was merged to the "31-x-y" branch.
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The frame view of the widget is an
ClientFrameViewLinux
instance only when bothframe
andclient_frame
booleans are set totrue
. Otherwise it is an instance of a different class and thus casting toClientFrameViewLinux
is incorrect and leads to crashes.Fix: #41839
cc @VerteDinde @ckerr
Checklist
npm test
passesRelease Notes
Notes: Fix crash on window maximize on X11