Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: calculate a hash for the Tag property of ToastNotification. #42239

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: calculate a hash for the Tag property of ToastNotification. #42239

merged 2 commits into from
May 24, 2024

Conversation

cucbin
Copy link
Contributor

@cucbin cucbin commented May 22, 2024 •
edited by codebytere
Loading

Description of Change

We encountered an issue on Windows, the notification won't popup when use web notification.
After our investigation. We found that when the URL exceeds a certain length, it will not popup the notification.
And it was caused by this change: #40242
In fact, the length of notification_id() will be affected by url, NotificationOptions, etc.

My solution is to calculate the hash of the notification_id() value.

Closes #42233
Closes #40433

Release Notes

Notes: none.

@welcome Welcome
Copy link

welcome bot commented May 22, 2024

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 22, 2024
@cucbin cucbin marked this pull request as ready for review May 23, 2024 05:10
@codebytere codebytere self-requested a review May 23, 2024 09:04
codebytere
codebytere requested changes May 23, 2024
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! It's also failing lint - we'll need to address that before this can be merged as well.

shell/browser/notifications/win/windows_toast_notification.cc Outdated Show resolved Hide resolved
codebytere
codebytere approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😁

@cucbin
Copy link
Contributor Author

cucbin commented May 24, 2024

@codebytere
I am not authorized to merge the PR, could you please help do it?
Thanks.

@codebytere codebytere added the semver/patch backwards-compatible bug fixes label May 24, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 24, 2024
@codebytere codebytere added new-pr 🌱 PR opened in the last 24 hours target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. labels May 24, 2024
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels May 24, 2024
@codebytere codebytere merged commit 3ffa35d into electron:main May 24, 2024
30 checks passed
@welcome Welcome
Copy link

welcome bot commented May 24, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk Release Clerk
Copy link

release-clerk bot commented May 24, 2024

No Release Notes

This was referenced May 24, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 24, 2024

I have automatically backported this PR to "31-x-y", please check out #42272

@trop trop bot mentioned this pull request May 24, 2024
Merged
@trop trop bot removed the target/31-x-y PR should also be added to the "31-x-y" branch. label May 24, 2024
@trop
Copy link
Contributor

trop bot commented May 24, 2024

I have automatically backported this PR to "29-x-y", please check out #42273

@trop
Copy link
Contributor

trop bot commented May 24, 2024

I have automatically backported this PR to "30-x-y", please check out #42274

@trop trop bot added in-flight/30-x-y merged/31-x-y PR was merged to the "31-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/31-x-y in-flight/30-x-y in-flight/29-x-y labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
2 participants
@cucbin @codebytere