fix: potential null dereference in normalizeSpawnArguments() patch #42260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use upstream's practice of using `env = options.env || process.env`. Previously, we were unconditionally assigning CRASHDUMP_SIGNAL_FD and CRASHPAD_HANDLER_PID to options.env.
ckerr
added
semver/patch
codebytere
approved these changes
May 24, 2024
codebytere
deleted the
fix/potential-null-object-ref-in-normalizeSpawnArguments
branch
|
No Release Notes |
|
I was unable to backport this PR to "29-x-y" cleanly; |
trop
bot
removed
the
target/29-x-y
|
I was unable to backport this PR to "30-x-y" cleanly; |
trop
bot
added
needs-manual-bp/29-x-y
and removed
target/30-x-y
|
I was unable to backport this PR to "31-x-y" cleanly; |
trop
bot
added
needs-manual-bp/30-x-y
needs-manual-bp/31-x-y
and removed
target/31-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The old version of this patch has code that can call
options.env.foo = bareven ifoptions.envis null. This PR moves the pre-existing upstream Node lineconst env = options.env || process.envto be declared earlier in the function so that we can useenvsafely here.CC @deepak1556, @mlaurencin since this upstreams a minor cleanup from the Microsoft build's patchset
CC @VerteDinde -- Keeley, I can't tell if you wrote the patch but your name is in the
From:header so you're a stakeholder 馃樃Checklist
npm testpassesRelease Notes
Notes: none