build: re-enable self-cert codesigning on x64 macOS #42576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
MarshallOfSound
approved these changes
Jun 19, 2024
jkleinsc
approved these changes
Jun 19, 2024
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Re-enables self-certified codesigning on macOS an associated tests. It continues to fail mysteriously on arm64 - but we weren't running this on arm64 in Circle either so let's at least bring it back on x64.
Successful build: https://github.com/electron/electron/actions/runs/9572243925
Checklist
npm testpassesRelease Notes
Notes: none