Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch-dependent interfaces in Web Workers #42579

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: fetch-dependent interfaces in Web Workers #42579

merged 1 commit into from
Jun 20, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #42577.

Addresses missing fetch-dependent interfaces in Web Workers using the same approach as in the renderer when nodeIntegrationInWorker is enabled. Also adds tests.

Checklist

Release Notes

Notes: Fixed an issue where fetch-dependent interfaces could be missing in Web Workers with nodeIntegrationInWorker enabled.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Jun 19, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2024
@codebytere codebytere force-pushed the fetch-dependent-interfaces-worker branch from bcd557e to 04a372d Compare June 19, 2024 08:55
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2024
@jkleinsc jkleinsc merged commit 3760893 into main Jun 20, 2024
17 checks passed
@jkleinsc jkleinsc deleted the fetch-dependent-interfaces-worker branch June 20, 2024 15:01
@release-clerk Release Clerk
Copy link

release-clerk bot commented Jun 20, 2024

Release Notes Persisted

Fixed an issue where fetch-dependent interfaces could be missing in Web Workers with nodeIntegrationInWorker enabled.

This was referenced Jun 20, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 20, 2024

I have automatically backported this PR to "32-x-y", please check out #42595

@trop trop bot mentioned this pull request Jun 20, 2024
Merged
@trop trop bot removed the target/32-x-y PR should also be added to the "32-x-y" branch. label Jun 20, 2024
@trop
Copy link
Contributor

trop bot commented Jun 20, 2024

I have automatically backported this PR to "30-x-y", please check out #42596

@trop
Copy link
Contributor

trop bot commented Jun 20, 2024

I have automatically backported this PR to "31-x-y", please check out #42597

@trop trop bot added in-flight/30-x-y in-flight/31-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. in-flight/30-x-y labels Jun 20, 2024
@trop trop bot added merged/32-x-y PR was merged to the "32-x-y" branch. and removed in-flight/31-x-y in-flight/32-x-y labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: missing fetch-dependent interfaces in web workers
2 participants
@codebytere @jkleinsc