Add "remote-debugging-port" switch, fixes #498. #521
Conversation
| @@ -89,6 +90,9 @@ void AtomBrowserMainParts::PreMainMessageLoopRun() { | |||
| static_cast<content::BrowserContext*>(AtomBrowserContext::Get())-> | |||
| GetRequestContext(); | |||
|
|
|||
| devtools_delegate_.reset( | |||
| new AtomDevToolsDelegate(AtomBrowserContext::Get())); | |||
|
|
|||
There was a problem hiding this comment.
We should only create the devtools delegate when user has specified a remote debugging port.
|
@hokein Can you move the code to https://github.com/brightray/brightray? Our current design is to handle all devtools related things in brightray when possible. |
|
@zcbenz, Done. |
| @@ -79,6 +81,12 @@ void AtomBrowserMainParts::PreMainMessageLoopRun() { | |||
| static_cast<content::BrowserContext*>(AtomBrowserContext::Get())-> | |||
| GetRequestContext(); | |||
|
|
|||
| if (CommandLine::ForCurrentProcess()->HasSwitch( | |||
There was a problem hiding this comment.
This code had better be put in brightray::BrowserMainParts.
There was a problem hiding this comment.
How about putting the devtools_delegate_ to brightray::BrowserMainParts? In this way, there is no modification on atom-shell parts.
There was a problem hiding this comment.
Yeah, all the code of this feature should be put in brightray, in atom-shell we only need to update the vendor/brightray.
There was a problem hiding this comment.
Done. Close this issue since no need to modify the code of atom-shell.
@zcbenz, please take a look, thanks!