New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove callbackId when callback is removed from registry #6218

Merged
merged 1 commit into from Jun 24, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Jun 24, 2016

Close #6050.

@zcbenz zcbenz merged commit 5826a8f into master Jun 24, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3517607 succeeded in 42s
Details
electron-linux-ia32 Build #3517608 succeeded in 37s
Details
electron-linux-x64 Build #3517609 succeeded in 122s
Details
electron-mas-x64 Build #1698 succeeded in 7 min 52 sec
Details
electron-osx-x64 Build #1707 succeeded in 11 min
Details
electron-win-ia32 Build #702 succeeded in 7 min 44 sec
Details
electron-win-x64 Build #691 succeeded in 11 min
Details

@zcbenz zcbenz deleted the clean-up-callback-id branch Jun 24, 2016

@mgparrish

This comment has been minimized.

mgparrish commented Jul 23, 2016

I checked my issue (6050) using version v 1.2.8, it still has the bug. The callback is never performed using the code I posted in 6050. I hadn't checked in V 1.2.6 but presume it wasn't working there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment