Fixes buffer size in offscreen mode #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -379,6 +379,13 @@ OffScreenRenderWidgetHostView::~OffScreenRenderWidgetHostView() { | |||
| #if defined(OS_MACOSX) | |||
| DestroyPlatformWidget(); | |||
| #endif | |||
|
|
|||
| if (copy_frame_generator_.get()) | |||
| copy_frame_generator_.reset(NULL); | |||
5 tasks
| @@ -1345,11 +1345,19 @@ bool WebContents::IsOffScreen() const { | |||
|
|
|||
| void WebContents::OnPaint(const gfx::Rect& dirty_rect, | |||
| const gfx::Size& bitmap_size, | |||
| const int pixel_size, | |||
| void* bitmap_pixels) { | |||
| v8::MaybeLocal<v8::Object> buffer = node::Buffer::New( | |||
There was a problem hiding this comment.
Calling node::Buffer::New means the data is transferred to Node to manage, so once the returned data is garbage collected the bitmap_pixels would be deleted, while it is still being managed by someone class. I think we should do node::Buffer::Copy here.
fixed buffer size calculation (we actually send the whole image, not just the dirty part) removed the unnecessary resets and const now we use Copy instead of New
brenca
force-pushed
the
offscreen-rendering-fixes
branch
from
7c55be7
to
1b0af6f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the buffer size issue in the
'paint'event in offscreen mode. #6704Also resets some properties in
OffScreenRenderWidgetHostView's destructor.