New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark update available until restart #6780

Merged
merged 3 commits into from Aug 9, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 8, 2016

Previously calling autoUpdate.checkForUpdates() twice with a successful update followed by a call to quitAndInstall would emit an error since updateAvailable would be set back to false the second time it was called when the first time successfully downloaded and installed an update.

This pull request removes the clearing of the flag so that updateAvailable is true until restart.

Closes #6647

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 9, 2016

👍

@zcbenz zcbenz merged commit 01f92a8 into master Aug 9, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3797643 succeeded in 48s
Details
electron-linux-ia32 Build #3797644 succeeded in 44s
Details
electron-linux-x64 Build #3797645 succeeded in 84s
Details
electron-mas-x64 Build #2147 succeeded in 7 min 10 sec
Details
electron-osx-x64 Build #2145 succeeded in 7 min 29 sec
Details
electron-win-ia32 Build #1166 succeeded in 6 min 25 sec
Details
electron-win-x64 Build #1152 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the update-available-check branch Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment