Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow settings of launch args when using defaultProtocol #6858

Merged
merged 8 commits into from Aug 22, 2016
Merged

Allow settings of launch args when using defaultProtocol #6858

merged 8 commits into from Aug 22, 2016

Commits on Aug 16, 2016

  1. Allow client to specify EXE file and args to set as default handler 

    * Optional path param to setAsDefaultProtocolClient
* Optional args param to setAsDefaultProtocolClient
    @MarshallOfSound
    MarshallOfSound committed Aug 16, 2016
    Copy the full SHA
    e5daf63 View commit details
    Browse the repository at this point in the history

  2. Document the optional params

    @MarshallOfSound
    MarshallOfSound committed Aug 16, 2016
    Copy the full SHA
    db27da5 View commit details
    Browse the repository at this point in the history

  3. Clarify defaults

    @MarshallOfSound
    MarshallOfSound committed Aug 16, 2016
    Copy the full SHA
    ce98659 View commit details
    Browse the repository at this point in the history

  4. Fix cpp linting issues

    @MarshallOfSound
    MarshallOfSound committed Aug 16, 2016
    Copy the full SHA
    14154e3 View commit details
    Browse the repository at this point in the history

  5. Pass args through correctly

    @MarshallOfSound
    MarshallOfSound committed Aug 16, 2016
    Copy the full SHA
    88bf089 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. Return boolean instead of empty string when error occurs. Update docs

    @MarshallOfSound
    MarshallOfSound committed Aug 18, 2016
    Copy the full SHA
    ca971e9 View commit details
    Browse the repository at this point in the history

  2. Use base::string16 and base::JoinString instead of custom methods

    @MarshallOfSound
    MarshallOfSound committed Aug 18, 2016
    Copy the full SHA
    7324611 View commit details
    Browse the repository at this point in the history

  3. Fix linting issues

    @MarshallOfSound
    MarshallOfSound committed Aug 18, 2016
    Copy the full SHA
    ab7899d View commit details
    Browse the repository at this point in the history