New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call setCanSelectHiddenExtension on save dialogs #6872

Merged
merged 1 commit into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 16, 2016

The Hide Extension button only appears to be application to save dialogs and has no effect on open dialogs when toggled, so only show it on save dialogs.

Showing this button for open dialogs was previously causing the New Folder button to overlay on top of the Hide Extension button.

Closes #6866

@kevinsawicki kevinsawicki changed the title from Only call setCanSelectHiddenExtension for save dialogs to Only call setCanSelectHiddenExtension on save dialogs Aug 16, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 17, 2016

👍

@zcbenz zcbenz merged commit 0b7b6b3 into master Aug 17, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3867515 succeeded in 46s
Details
electron-linux-ia32 Build #3867516 succeeded in 43s
Details
electron-linux-x64 Build #3867517 succeeded in 79s
Details
electron-mas-x64 Build #2214 succeeded in 7 min 23 sec
Details
electron-osx-x64 Build #2216 succeeded in 8 min 0 sec
Details
electron-win-ia32 Build #1240 succeeded in 6 min 23 sec
Details
electron-win-x64 Build #1222 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the only-show-extension-button-on-save-dialog branch Aug 17, 2016

@joshaber joshaber referenced this pull request Aug 23, 2016

Merged

Bump electron #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment