Upgrade to Chrome 53 and Node 6.5.0

[zcbenz]

Debug build compiles on:

• OS X
• Linux
• Windows

Release build compiles on:

• OS X
• Linux
• Windows

Tests passing on:

• OS X
• Linux
• Windows

Merge:

• Upgrade to Chrome 53 libchromiumcontent#230
• Upgrade to Chrome 53 electron-archive/brightray#247

[zcbenz]

This is ready to go, testings will be appreciated.

Prebuilt binaries for Chrome 53 build can be found at: https://github.com/electron/electron/releases/tag/untagged-022e0d01224f774e7712

[deepak1556]

Verified some stuff on linux for which we don't have tests.

• using geolocation api with enableHighAccuracy option crashes, verified not to crash on previous versions.

var options = {
  enableHighAccuracy: true
};

function success(pos) {
  var crd = pos.coords;

  console.log('Your current position is:');
  console.log('Latitude : ' + crd.latitude);
  console.log('Longitude: ' + crd.longitude);
  console.log('More or less ' + crd.accuracy + ' meters.');
};

function error(err) {
  console.warn('ERROR(' + err.code + '): ' + err.message);
};

navigator.geolocation.getCurrentPosition(success, error, options);

stacktrace:

#5 0x7fcae15d5776 content::WifiDataProvider::DoRunCallbacks()
#6 0x7fcadf360696 base::debug::TaskAnnotator::RunTask()
#7 0x7fcadf37f135 base::MessageLoop::RunTask()
#8 0x7fcadf37f448 base::MessageLoop::DeferOrRunPendingTask()
#9 0x7fcadf37f7db base::MessageLoop::DoWork()
#10 0x7fcadf380b9a base::MessagePumpDefault::Run()
#11 0x7fcadf39f23e base::RunLoop::Run()
#12 0x7fcadf37e84a base::MessageLoop::Run()
#13 0x7fcadf3c9fee base::Thread::ThreadMain()
#14 0x7fcadf3c54b3 <unknown>
#15 0x7fcadd4db454 start_thread
#16 0x7fcad72647df __GI___clone
  r8: 0000000000000000  r9: 000000000000000e r10: 000027ef172ee330 r11: 0000000000000000
 r12: 000027ef173ee9c0 r13: 000027ef172ecf78 r14: 00007fcab44c17b0 r15: 000027ef170a7b80
  di: 000027ef170a7b80  si: 0000000000000000  bp: 00007fcae28fa110  bx: 000027ef1736ce60
  dx: 000000003d1842c0  ax: 00007fcae2a73dd8  cx: fffff79c842fa500  sp: 00007fcab44c16c0
  ip: 00007fcae28f725d efl: 0000000000010246 cgf: 002b000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

• DevTools - workspace, network throttling, file and color chooser, search works fine.
• network switches are good to go (haven't verified NTLM stuff, but should be fine).

[deepak1556]

option should be removed from docs ?

[zcbenz]

There is no such member in blink::WebMouseWheelEvent anymore.

[brenca]

If we want to maintain backwards compatibility, we could use the method that replaced that member https://codereview.chromium.org/2052663004/patch/80001/90009 (but I'm not sure that's a widely used feature anyway, might not worth the hassle)

[zcbenz]

👍

[tarjei]

@zcbenz I tried to use the link above to the prebuilt binaries, but got a 404.

[ghost]

maybe this is not place to ask about this . but what is the percentage of es6 in electron 1.4.0 ?

[MarshallOfSound]

@alnour-altegani http://node.green/

[raffaeler]

The .node-version file (root folder) is still 6.3.0