New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Chrome 53 and Node 6.5.0 #7104

Merged
merged 16 commits into from Sep 14, 2016

Conversation

Projects
None yet
6 participants
@zcbenz
Contributor

zcbenz commented Sep 6, 2016

Debug build compiles on:

  • OS X
  • Linux
  • Windows

Release build compiles on:

  • OS X
  • Linux
  • Windows

Tests passing on:

  • OS X
  • Linux
  • Windows

Merge:

@zcbenz zcbenz changed the title from Upgrade to Chrome 53 to Upgrade to Chrome 53 and Node 6.5.0 Sep 8, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 8, 2016

This is ready to go, testings will be appreciated.

Prebuilt binaries for Chrome 53 build can be found at: https://github.com/electron/electron/releases/tag/untagged-022e0d01224f774e7712

@deepak1556

This comment has been minimized.

Member

deepak1556 commented Sep 8, 2016

Verified some stuff on linux for which we don't have tests.

  • using geolocation api with enableHighAccuracy option crashes, verified not to crash on previous versions.
var options = {
  enableHighAccuracy: true
};

function success(pos) {
  var crd = pos.coords;

  console.log('Your current position is:');
  console.log('Latitude : ' + crd.latitude);
  console.log('Longitude: ' + crd.longitude);
  console.log('More or less ' + crd.accuracy + ' meters.');
};

function error(err) {
  console.warn('ERROR(' + err.code + '): ' + err.message);
};

navigator.geolocation.getCurrentPosition(success, error, options);

stacktrace:

#5 0x7fcae15d5776 content::WifiDataProvider::DoRunCallbacks()
#6 0x7fcadf360696 base::debug::TaskAnnotator::RunTask()
#7 0x7fcadf37f135 base::MessageLoop::RunTask()
#8 0x7fcadf37f448 base::MessageLoop::DeferOrRunPendingTask()
#9 0x7fcadf37f7db base::MessageLoop::DoWork()
#10 0x7fcadf380b9a base::MessagePumpDefault::Run()
#11 0x7fcadf39f23e base::RunLoop::Run()
#12 0x7fcadf37e84a base::MessageLoop::Run()
#13 0x7fcadf3c9fee base::Thread::ThreadMain()
#14 0x7fcadf3c54b3 <unknown>
#15 0x7fcadd4db454 start_thread
#16 0x7fcad72647df __GI___clone
  r8: 0000000000000000  r9: 000000000000000e r10: 000027ef172ee330 r11: 0000000000000000
 r12: 000027ef173ee9c0 r13: 000027ef172ecf78 r14: 00007fcab44c17b0 r15: 000027ef170a7b80
  di: 000027ef170a7b80  si: 0000000000000000  bp: 00007fcae28fa110  bx: 000027ef1736ce60
  dx: 000000003d1842c0  ax: 00007fcae2a73dd8  cx: fffff79c842fa500  sp: 00007fcab44c16c0
  ip: 00007fcae28f725d efl: 0000000000010246 cgf: 002b000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
  • DevTools - workspace, network throttling, file and color chooser, search works fine.
  • network switches are good to go (haven't verified NTLM stuff, but should be fine).
@@ -238,7 +238,6 @@ bool Converter<blink::WebMouseWheelEvent>::FromV8(
dict.Get("accelerationRatioX", &out->accelerationRatioX);
dict.Get("accelerationRatioY", &out->accelerationRatioY);
dict.Get("hasPreciseScrollingDeltas", &out->hasPreciseScrollingDeltas);
dict.Get("canScroll", &out->canScroll);

This comment has been minimized.

@deepak1556

deepak1556 Sep 8, 2016

Member

option should be removed from docs ?

This comment has been minimized.

@zcbenz

zcbenz Sep 8, 2016

Contributor

There is no such member in blink::WebMouseWheelEvent anymore.

This comment has been minimized.

@brenca

brenca Sep 9, 2016

Member

If we want to maintain backwards compatibility, we could use the method that replaced that member https://codereview.chromium.org/2052663004/patch/80001/90009 (but I'm not sure that's a widely used feature anyway, might not worth the hassle)

This comment has been minimized.

@zcbenz

zcbenz Sep 9, 2016

Contributor

👍

result.Set("finalUpdate", final_update);
Emit("found-in-page", result);
}
result.Set("requestId", request_id);

This comment has been minimized.

@deepak1556

deepak1556 Sep 8, 2016

Member

found-in-page event data in docs are marked optional, should be updated. Wouldn't it be better to emit the event only in situations when atleast one match is found or if its the finalUpdate ?

This comment has been minimized.

@zcbenz

zcbenz Sep 8, 2016

Contributor

I was trying to match the old behavior since the behavior of FindReply has changed, I don't know why this event was emitting when finalUpdate is false before.

This comment has been minimized.

@deepak1556

deepak1556 Sep 9, 2016

Member

I was trying to match the old behavior since the behavior of FindReply has changed

👍

I don't know why this event was emitting when finalUpdate is false before.

yeah previously the event messed up, you wouldn't get the right selectionArea when its the finalUpdate. So the event was emitted once when a match is found with its selectionArea and once when its the finalUpdate with total matches.

@tarjei

This comment has been minimized.

tarjei commented Sep 13, 2016

@zcbenz I tried to use the link above to the prebuilt binaries, but got a 404.

@zcbenz zcbenz merged commit 4627311 into master Sep 14, 2016

2 of 6 checks passed

electron-mas-x64 Build #2373 failed in 6 min 40 sec
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
electron-linux-x64 Build #4128461 failed in 109s
Details
electron-linux-arm Build #4128459 succeeded in 65s
Details
electron-linux-ia32 Build #4128460 succeeded in 58s
Details

@zcbenz zcbenz deleted the chrome53 branch Sep 14, 2016

@ghost

This comment has been minimized.

ghost commented Sep 17, 2016

maybe this is not place to ask about this . but what is the percentage of es6 in electron 1.4.0 ?

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Sep 18, 2016

@alnour-altegani http://node.green/

@raffaeler

This comment has been minimized.

raffaeler commented Oct 17, 2016

The .node-version file (root folder) is still 6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment