🐧 Add support for different trash implementations #7178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the trash implemantation in MoveItemToTrash selectable via an environment variable
|
Thanks! |
|
This was the fix for me on Manjaro xfce 17.0.1: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for kioclient, kioclient5 and trash-cli in MoveItemToTrash.
The desired implementation has to be specified in the environment variable
ELECTRON_TRASH. If none is it will fallback togvfs-trash. Valid values forELECTRON_TRASHare:It will also fallback to
gvfs-trashif the value ofELECTRON_TRASHis none of the above.This fixes:
and allows users of kde, xfce and other desktop environments to delete files and folders without the need of gvfs.