New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:penguin: Add support for different trash implementations #7178

Merged
merged 1 commit into from Sep 16, 2016

Conversation

Projects
None yet
3 participants
@aichingm
Contributor

aichingm commented Sep 12, 2016

Add support for kioclient, kioclient5 and trash-cli in MoveItemToTrash.

The desired implementation has to be specified in the environment variable ELECTRON_TRASH . If none is it will fallback to gvfs-trash. Valid values for ELECTRON_TRASH are:

  • kioclient5
  • kioclient
  • trash-cli

It will also fallback to gvfs-trash if the value of ELECTRON_TRASH is none of the above.

This fixes:

and allows users of kde, xfce and other desktop environments to delete files and folders without the need of gvfs.

🐧 Add support for different trash implementations
Make the trash implemantation in MoveItemToTrash selectable via an environment variable
@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 16, 2016

Thanks!

@zcbenz zcbenz merged commit 20d5a50 into electron:master Sep 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rsese rsese marked this as a duplicate of atom/atom#14940 Jul 3, 2017

@rsese rsese referenced this pull request Jul 3, 2017

Closed

Linux moving to trash #14940

1 of 1 task complete
@harps116

This comment has been minimized.

harps116 commented Jul 8, 2017

This was the fix for me on Manjaro xfce 17.0.1:

$ ELECTRON_TRASH=trash-cli atom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment