Use callback dialog methods in RunFileChooser #8745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
async-web-dialog-helper
branch
from
fcd0db9
to
aa38d2d
Compare
kevinsawicki
force-pushed
the
async-web-dialog-helper
branch
from
aa38d2d
to
527360f
Compare
kevinsawicki
changed the title
kevinsawicki
force-pushed
the
async-web-dialog-helper
branch
from
527360f
to
469b951
Compare
deepak1556
reviewed
Feb 23, 2017
atom/browser/web_dialog_helper.cc
Outdated
| @@ -26,6 +28,94 @@ | |||
|
|
|||
| namespace { | |||
|
|
|||
| class FileSelectHelper : public base::RefCountedThreadSafe< | |||
There was a problem hiding this comment.
this can be just base::RefCounted, I don't see this class being used across threads. Also its good practice to make destructor private for ref counted classes.
deepak1556
reviewed
Feb 23, 2017
atom/browser/web_dialog_helper.cc
Outdated
|
|
||
| void ShowOpenDialog(const file_dialog::DialogSettings& settings) { | ||
| auto callback = base::Bind(&FileSelectHelper::OnOpenDialogDone, | ||
| base::Unretained(this)); |
There was a problem hiding this comment.
its not necessary for unretained wrapper since its ref counted, same with other bind call.
|
Thanks @deepak1556 for taking a look at this 👍 |
deepak1556
approved these changes
Feb 23, 2017
deepak1556
reviewed
Feb 23, 2017
atom/browser/web_dialog_helper.cc
Outdated
| @@ -16,7 +16,9 @@ | |||
| #include "base/strings/utf_string_conversions.h" | |||
| #include "chrome/common/pref_names.h" | |||
| #include "components/prefs/pref_service.h" | |||
| #include "content/public/browser/browser_thread.h" | |||
There was a problem hiding this comment.
Minor change, this header is not used.
kevinsawicki
force-pushed
the
async-web-dialog-helper
branch
from
186ad70
to
a62c2f9
Compare
kevinsawicki
force-pushed
the
async-web-dialog-helper
branch
from
7428b6a
to
ef085a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request switches the open and save dialogs opened in
WebDialogHelper::RunFileChooserto be callback-based instead of synchronous.Inspired by https://cs.chromium.org/chromium/src/chrome/browser/file_select_helper.h
Closes #8457