New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use callback dialog methods in RunFileChooser #8745

Merged
merged 5 commits into from Feb 24, 2017

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Feb 23, 2017

This pull request switches the open and save dialogs opened in WebDialogHelper::RunFileChooser to be callback-based instead of synchronous.

Inspired by https://cs.chromium.org/chromium/src/chrome/browser/file_select_helper.h

  • Manually test on macOS
  • Manually test on Windows
  • Manually test on Linux

Closes #8457

@kevinsawicki kevinsawicki changed the title from [WIP] Use callback dialog methods in RunFileChooser to Use callback dialog methods in RunFileChooser Feb 23, 2017

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Feb 23, 2017

Contributor

Thanks @deepak1556 for taking a look at this 👍

Contributor

kevinsawicki commented Feb 23, 2017

Thanks @deepak1556 for taking a look at this 👍

@kevinsawicki kevinsawicki merged commit 5819acb into master Feb 24, 2017

7 of 9 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #5636136 was skipped due to a previously successful build of the same tree.
Details
electron-linux-ia32 Build #5636137 was skipped due to a previously successful build of the same tree.
Details
electron-linux-x64 Build #5636138 was skipped due to a previously successful build of the same tree.
Details
electron-mas-x64 Build #3492 succeeded in 8 min 4 sec
Details
electron-osx-x64 Build #3502 succeeded in 8 min 35 sec
Details
electron-win-ia32 Build #2509 succeeded in 8 min 1 sec
Details
electron-win-x64 Build #2485 succeeded in 8 min 5 sec
Details

@kevinsawicki kevinsawicki deleted the async-web-dialog-helper branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment