Support scale factor in more NativeImage APIs #8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
changed the title
kevinsawicki
force-pushed
the
to-data-url-scale-factor
branch
from
f2f1df5
to
31cae8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a
scaleFactoroption, defaulting to1.0, to the followingNativeImageAPIs:toDataURLtoBitmapgetBitmaptoPNGThis can be used when multiple representations of an image exist and you want access to a specific representation for a scale factor.
This also updates
toDataURLandtoPNGto work when there is no1xscale factor representation. This can occur for images returned via other APIs such asapp.getFileIcon.Closes #8767