New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libcc for v8 snapshot patch #8922

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Mar 14, 2017

This change pulls in electron/libchromiumcontent#271 which removes the verification of snapshot data on Windows.

This has been removed upstream in https://codereview.chromium.org/2680653002 and this backports it to 1.3.x so Atom can use it via atom/atom#13916

@as-cii

This comment has been minimized.

Member

as-cii commented Mar 14, 2017

Amazing, thank you so much! ❤️

@kevinsawicki kevinsawicki merged commit 9a3cf30 into 1-3-x Mar 14, 2017

6 of 7 checks passed

electron-linux-x64 Build #5855720 failed in 101s
Details
electron-linux-arm Build #5855718 was skipped due to a previously successful build of the same tree.
Details
electron-linux-ia32 Build #5855719 was skipped due to a previously successful build of the same tree.
Details
electron-mas-x64 Build #3641 succeeded in 6 min 13 sec
Details
electron-osx-x64 Build #3645 succeeded in 6 min 32 sec
Details
electron-win-ia32 Build #2654 succeeded in 6 min 22 sec
Details
electron-win-x64 Build #2627 succeeded in 6 min 41 sec
Details

@kevinsawicki kevinsawicki deleted the v8-snapshot-patch branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment