net: allow controlling redirects #9007
Conversation
deepak1556
force-pushed
the
net_redirect_patch
branch
from
cedc2b3
to
6afbda5
Compare
|
@deepak1556 does this need some user-facing documentation changes? |
|
@zeke yup, have added the docs. Please take a look, thanks! |
docs/api/client-request.md
Outdated
| * `redirect` String (optional) - The redirect mode for this request. Should be | ||
| one of `follow`, `error` or `manual`. Defaults to `follow`. When mode is `error`, | ||
| any redirection will be aborted. When mode is `manual` the redirection will be | ||
| deferred until [`request.followRedirect`](#requestfollowRedirecct) is invoked, listen to [`redirect`](#event-redirect) event in |
There was a problem hiding this comment.
requestfollowRedirecct → requestfollowRedirect
There was a problem hiding this comment.
invoked, listen to → invoked. Listen for the
deepak1556
force-pushed
the
net_redirect_patch
branch
from
0ccd159
to
b551f51
Compare
|
@arantes555 can you verify if this PR helps with your use case , thanks! |
spec/api-net-spec.js
Outdated
| it('should throw if given an invalid redirect mode', function (done) { | ||
| const requestUrl = '/requestUrl' | ||
| try { | ||
| const urlRequest = net.request({ |
There was a problem hiding this comment.
Would using assert.throws make sense here?
There was a problem hiding this comment.
I was reusing the existing spec. Have changed it, Thanks!
|
@deepak1556 Looks good to me! Would be even better if it were possible to know whether or not a redirect happened in follow mode :) But hey, it's possible to do it manually. |
deepak1556
force-pushed
the
net_redirect_patch
branch
from
b551f51
to
b14c4dc
Compare
|
Looks good to me 👍 Thanks @deepak1556 🎆 |
Introduces redirect mode option on
net.requestthat takes one offollow, error, manualand defaults tofollow. Inmanualmode aredirectevent is emitted on the request object withstatusCode, method, newURL, responseHeaders. Callingrequest.followRedirectwill continue with the redirection in manual mode andrequest.abortto cancel the request.Fixes #8868