Fix net module to accept non-string header values #9062
Conversation
| @@ -255,7 +255,7 @@ class ClientRequest extends EventEmitter { | |||
|
|
|||
| const key = name.toLowerCase() | |||
| this.extraHeaders[key] = value | |||
| this.urlRequest.setExtraHeader(name, value) | |||
| this.urlRequest.setExtraHeader(name, value.toString()) | |||
There was a problem hiding this comment.
Looking at line 249, we only check against undefined, which means null could get through to here and the error would be a bit confusing, maybe the value === undefined check could be updated to value == null since that is the check we typically use in lots of places. What do you think?
spec/api-net-spec.js
Outdated
| response.end() | ||
| break | ||
| default: | ||
| assert(false) |
There was a problem hiding this comment.
Maybe an assert.equal(request.url, requestUrl) before here would be better so when this fails we know what request.url was.
spec/api-net-spec.js
Outdated
| const statusCode = response.statusCode | ||
| assert.equal(statusCode, 200) | ||
| response.pause() | ||
| response.on('data', function (chunk) { |
There was a problem hiding this comment.
Is this needed? Looks like it isn't using the data.
spec/api-net-spec.js
Outdated
| @@ -364,6 +364,51 @@ describe('net module', function () { | |||
| urlRequest.end() | |||
| }) | |||
|
|
|||
| it('should be able to set a non-string object as header value', function (done) { | |||
There was a problem hiding this comment.
as header... -> as a header...
tarruda
force-pushed
the
stringify-headers-in-net-module
branch
from
319689d
to
f3248e8
Compare
|
Maybe we should update the docs as well to broaden the https://electron.atom.io/docs/api/client-request/#requestsetheadername-value |
This is required to be compatible with node.js http module.
tarruda
force-pushed
the
stringify-headers-in-net-module
branch
from
f3248e8
to
b3cf00a
Compare
Done |
|
Thanks for updating this 👍 ⚡️ |
This is required to be compatible with node.js http module.
For the record, I found this issue when trying to make the request module to work with electron's
netmodule.