Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove page url check during history.pushState #9468

Merged
merged 4 commits into from Jun 5, 2017
Merged

Remove page url check during history.pushState #9468

merged 4 commits into from Jun 5, 2017

Commits on May 23, 2017

  1. Add test for electron#9468

    @tonyganch
    tonyganch committed May 23, 2017
    Copy the full SHA
    6d64336 View commit details
    Browse the repository at this point in the history

  2. Remove page url check in history.pushState 

    Current implementation of NavigationController does not allow using
`history.pushState()` if page url is not changed.
It worked by mistake in versions < 1.3.6 and got visible after fix 180a77e.
    @tonyganch
    tonyganch committed May 23, 2017
    Copy the full SHA
    3a9b035 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2017

  1. Move pushState spec chromium-spec with other history specs

    @kevinsawicki
    kevinsawicki committed Jun 5, 2017
    Copy the full SHA
    777b5b1 View commit details
    Browse the repository at this point in the history

  2. Load URL after registering listener

    @kevinsawicki
    kevinsawicki committed Jun 5, 2017
    Copy the full SHA
    af1d0c4 View commit details
    Browse the repository at this point in the history