This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Support a new language query param
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should make it easier for us to diagnose issues during our upcoming call with the Crowdin team |
test/index.js
Outdated
| $('body').text().should.not.include('fenêtres') | ||
|
|
||
| $ = await get('/docs/api/browser-window?language=fr-FR') | ||
| $('body').text().should.include('fenêtres') |
There was a problem hiding this comment.
Should we swap the order of these two tests, so we know the ?language=fr-FR param isn't affecting the language stored in the cookies?
vanessayuenn
approved these changes
Jan 23, 2018
|
Oops. The query param is persisting in the cookie. Turns out this is a feature of I guess that shows that this testing strategy doesn't account for user state. Working on a fix. |
zeke
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a
?language=query param to be added to any URL to view that URL in the target language. This does not have an effect on the visitor's language settings (or lack thereof). In other words, if my language is English and I view/docs/api/app?language=fr-FR, I will only see that one page in French. If I click any links or remove the query param from the URL, content will still be displayed in English.