This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryMuse
added
wip
DO NOT MERGE, Work in Progress
and removed
wip
DO NOT MERGE, Work in Progress
labels
Jan 22, 2019
sofianguy
reviewed
Apr 18, 2019
sofianguy
suggested changes
Apr 18, 2019
sofianguy
approved these changes
Apr 19, 2019
MarshallOfSound
suggested changes
Apr 19, 2019
Co-Authored-By: ckerr <ckerr@github.com>
5 tasks
add link to how to filter remote events tweak phrasing on download/install
minor grammar typo fixes
ckerr
approved these changes
Apr 22, 2019
4 tasks
miniak
reviewed
Apr 23, 2019
|
||
### Automatic modules with sandboxed webContents | ||
In order to improve security, the following modules are being deprecated for use directly via `require` and will instead need to be included via `remote.require` in a sandboxed webcontents: | ||
* `electron.screen` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is available via electron.remote.screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What change would you suggest ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miniak what change would you suggest here?
miniak
approved these changes
Apr 23, 2019
malept
reviewed
Apr 23, 2019
Co-Authored-By: ckerr <ckerr@github.com>
Co-Authored-By: ckerr <ckerr@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this started early so that we can begin to properly document new features, breaking changes, and deprecations now instead of waiting till the last minute 馃槒
Items to add: