Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset install state on error #90

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

dsanders11
Copy link
Member

Seeing some downstream issues in Fiddle where the install state for a version gets stuck when an error happens while installing or downloading. This PR ensures we reset the install state on error.

Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new tests 🙂 LGTM

@VerteDinde VerteDinde merged commit 2564541 into main Oct 3, 2023
17 checks passed
@VerteDinde VerteDinde deleted the fix-install-state-on-error branch October 3, 2023 20:26
@continuous-auth
Copy link

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants