fix: local versions are available not downloaded (#1528)

fix: Local versions are available not downloaded
electron · Jan 15, 2024 · 5cfd342 · 5cfd342
1 parent fe192ae
commit 5cfd342
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/src/renderer/components/settings-electron.tsx b/src/renderer/components/settings-electron.tsx
@@ -222,7 +222,7 @@ export const ElectronSettings = observer(
           <Checkbox
             checked={appState.showUndownloadedVersions}
             id="showUndownloadedVersions"
-            label="Not downloaded"
+            label="Not Downloaded"
             onChange={this.handleStateChange}
           />
         </FormGroup>
@@ -338,7 +338,7 @@ export const ElectronSettings = observer(
       const { state, source } = item;
       const isLocal = source === VersionSource.local;
       let icon: IconName = 'box';
-      let humanState = 'Downloaded';
+      let humanState = isLocal ? 'Available' : 'Downloaded';
 
       if (state === InstallState.downloading) {
         icon = 'cloud-download';
@@ -347,7 +347,7 @@ export const ElectronSettings = observer(
         // The only way for a local version to be missing
         // is for it to have been deleted. Mark as unavailable.
         icon = isLocal ? 'issue' : 'cloud';
-        humanState = isLocal ? 'Not available' : 'Not downloaded';
+        humanState = isLocal ? 'Not Available' : 'Not Downloaded';
       }
 
       return (

diff --git a/src/renderer/components/version-select.tsx b/src/renderer/components/version-select.tsx
@@ -71,7 +71,7 @@ export function getItemLabel({ source, state, name }: RunnableVersion): string {
   }
 
   const installStateLabels: Record<InstallState, string> = {
-    missing: 'Not downloaded',
+    missing: 'Not Downloaded',
     downloading: 'Downloading',
     downloaded: 'Downloaded',
     installing: 'Downloaded',

diff --git a/tests/renderer/components/__snapshots__/settings-electron-spec.tsx.snap b/tests/renderer/components/__snapshots__/settings-electron-spec.tsx.snap
@@ -98,7 +98,7 @@ exports[`ElectronSettings component renders 1`] = `
       <Blueprint3.Checkbox
         checked={false}
         id="showUndownloadedVersions"
-        label="Not downloaded"
+        label="Not Downloaded"
         onChange={[Function]}
       />
     </Blueprint3.FormGroup>
@@ -190,7 +190,7 @@ exports[`ElectronSettings component renders 1`] = `
                 icon="box"
               />
                
-              Downloaded
+              Available
             </span>
           </td>
           <td
@@ -275,7 +275,7 @@ exports[`ElectronSettings component renders 1`] = `
                 icon="cloud"
               />
                
-              Not downloaded
+              Not Downloaded
             </span>
           </td>
           <td

diff --git a/tests/renderer/components/__snapshots__/version-select-spec.tsx.snap b/tests/renderer/components/__snapshots__/version-select-spec.tsx.snap
@@ -5,7 +5,7 @@ exports[`VersionSelect component renderItem() renders an item 1`] = `
   active={true}
   disabled={false}
   icon="cloud"
-  label="Not downloaded"
+  label="Not Downloaded"
   multiline={false}
   onClick={[Function]}
   popoverProps={{}}

diff --git a/tests/renderer/components/version-select-spec.tsx b/tests/renderer/components/version-select-spec.tsx
@@ -141,7 +141,7 @@ describe('VersionSelect component', () => {
         state: missing,
       };
 
-      expect(getItemLabel(input)).toBe('Not downloaded');
+      expect(getItemLabel(input)).toBe('Not Downloaded');
     });
 
     it('returns the correct label for a version downloaded', () => {