fix: disabled download button for certain versions on darwin arm64

[Ayman161803]

Fixes #1017

I have disabled the download button for certain versions on darwin-arm64 as suggested by @dsanders11. I used the semver package to compare versions and added necessary stylings to commands.less. I have tested the changes made with results as given below.

The sample pic above is when condition process.platform==="linux" && process.arch==="x64" && semver.lt(item.version,"15.0.0") is applied to disable buttons

[dsanders11]

Thanks for taking this up @Ayman161803. I was actually referring to the download buttons under preferences when I made that issue, but you're right, the ones in the version select also have the same problem. 😄

Unfortunately I think this needs to be changed a bit. The changes to VersionSelect will break other functionality, such as in src/renderer/components/dialog-bisect.tsx, which makes use of the itemDisabled prop. There's multiple possible reasons a version in VersionSelect might be disabled, so any change needs to keep that in mind. Maybe that change for VersionSelect should be entirely contained within renderItem.

[dsanders11]

Let's also cover the download buttons in the Electron section in preferences.

[Ayman161803]

Hey @dsanders11! I have made recommended changes to this PR i.e. shifted disable logic to renderItem and disabled appropriate download buttons on preference page as well. Please take the look at the same. Here is a sample pic showing the changed preference section.

[coveralls]

Coverage increased (+0.03%) to 93.209% when pulling bc4961c on Ayman161803:patch-2 into f6ff9ea on electron:main.

[BlackHole1]

Before adding unit tests, you also need to update the snapshots.
Run yarn run test -- -u for automatic updates

[Ayman161803]

Hey @BlackHole1! I have committed recommended changes. I am pretty new to writing unit tests. Please recommend changes, if any.

Also, I tried updating snapshots as well but it doesn't look like they are getting updated.

[BlackHole1]

Component unit tests e.g.

@@ -0,0 +1,42 @@
diff --git a/tests/renderer/components/version-select-spec.tsx b/tests/renderer/components/version-select-spec.tsx
index 3a6bab6..16bdb50 100644
--- a/tests/renderer/components/version-select-spec.tsx
+++ b/tests/renderer/components/version-select-spec.tsx
@@ -14,12 +14,15 @@ import {
   renderItem,
   VersionSelect,
 } from '../../../src/renderer/components/version-select';
+import { disableDownload } from '../../../src/utils/disable-download';
 
 import { StateMock, VersionsMock } from '../../mocks/mocks';
 
 const { downloading, ready, unknown, unzipping } = VersionState;
 const { remote, local } = VersionSource;
 
+jest.mock('../../../src/utils/disable-download.ts');
+
 describe('VersionSelect component', () => {
   let store: StateMock;
 
@@ -85,6 +88,21 @@ describe('VersionSelect component', () => {
 
       expect(item).toBe(null);
     });
+
+    it('xxxxx', () => {
+      (disableDownload as any).mockReturnValueOnce(true);
+
+      const item = renderItem(mockVersion1, {
+        handleClick: () => ({}),
+        index: 0,
+        modifiers: { active: true, disabled: false, matchesPredicate: true },
+        query: '',
+      })!;
+
+      const ItemWrapper = shallow(item);
+
+      expect(ItemWrapper.find('.disabled-menu-tooltip')).toHaveLength(1);
+    });
   });
 
   describe('getItemLabel()', () => {

[BlackHole1]

LGTM.

cc: @dsanders11

[BlackHole1]

Done🚀. All unit test pass 🎉

[BlackHole1]

Ping @dsanders11

[dsanders11]

LGTM.

Sorry it took so long to circle back around on this @Ayman161803. Thanks for implementing it!

[Ayman161803]

Heyy! Thanks for having this merged.