feat: support AppImage releases

[robertgzr]

using @reforged/maker-appimage

Closes: #405
Signed-off-by: Robert Günzler r@gnzler.io

[robertgzr]

error @reforged/maker-appimage@3.3.0: The engine "node" is incompatible with this module. Expected version ">=19.0.0 || ^18.11.0 || ^16.1.0". Got "18.4.0"

😓

[erickzhao]

@robertgzr I think it would be fine to upgrade the Node.js version to the latest version of 18 LTS here:

fiddle/.circleci/config.yml

Lines 11 to 13 in a0b94dc

	- node/install:
	node-version: '18.4.0'
	- run: nvm use 18.4.0

[dsanders11]

Few things here.

• I think this should be feat:, not fix:, as it's adding a feature rather than fixing a bug (also minor nit, but lowercase Support would better match existing commit style 🙂)
• We could use just 18.16 for the changes to the CircleCI config, to ensure it uses the latest fix release
• Interestingly Node.js v18.16.1 seems to cause test failures (repros locally), so I'm investigating
• The updates to yarn.lock here cause a bit of a split brain since it uses newer @electron-forge versions than the rest. Ideally it would keep everything on 6.1.1 - I don't have an immediate solution off the top of my head

[dsanders11]

Looks like the test failures with Node.js v18.16.x are due to nodejs/node#47563, the fix for which may land soon in v18.16.2 - in the mean time let's use 18.15 for this PR, since that line doesn't have the bug (confirmed locally, and it's mentioned in the last comment on that issue).

[dsanders11]

We could use just 18.16 for the changes to the CircleCI config, to ensure it uses the latest fix release

Ugh, this is my bad - I forgot there's an issue where nvm-windows doesn't handle versions like that, only the full one - we should add a comment in the CircleCI config. So this should use 18.15.0. Apologies for the churn.

[robertgzr]

Ugh, this is my bad - I forgot there's an issue where nvm-windows doesn't handle versions like that, only the full one - we should add a comment in the CircleCI config. So this should use 18.15.0. Apologies for the churn.

looks like coreybutler/nvm-windows#709 (in 1.1.10) fixes that...

we get nvm from the windows orb, right? how would we know which version that is on 😅

[dsanders11]

we get nvm from the windows orb, right? how would we know which version that is on 😅

That comes from the CircleCI images where they bake new ones every once in a while, looks like they baked a new Windows Server 2022 one in May 2023 - win/default defaults to win/server-2022 currently. Clicking through that forum post to the commit, looks like this is the file which defines the versions of dev tools, including nvm-windows, and it's currently on 1.1.9. 😅

[robertgzr]

I included a comment mentioning the nvm-windows situation and linking to that ansible file :)

[dsanders11]

@robertgzr, now that this has shipped, a couple of observations:

• We should get the icon working properly - I played with it for a bit but wasn't successful
• The AppImage release doesn't work with launching Fiddle from the protocol handler via the docs

[robertgzr]

AppImage release doesn't work with launching Fiddle from the protocol handler via the docs

this requires some action on the system that wants this to work: https://docs.appimage.org/user-guide/run-appimages.html#integrating-appimages-into-the-desktop

it comes down to making the desktop file visible to the host, so it can detect the mimetype field and register fiddle as the handler for it, see https://manpages.debian.org/bookworm/desktop-file-utils/update-desktop-database.1.en.html

i guess we could document this?

[dsanders11]

I included a comment mentioning the nvm-windows situation and linking to that ansible file :)

I poked CircleCI and they've updated nvm-windows on the latest Windows Server 2022 image, but it hasn't made it's way to being the current tag yet. Confirmed it resolves the issue: https://app.circleci.com/pipelines/github/electron/fiddle/991/workflows/5321ebad-4d4d-4ce3-bb65-fa45ec243649/jobs/3594