Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lower-case names for show-me-templates #174

Merged
merged 1 commit into from
Feb 21, 2019
Merged

fix: Lower-case names for show-me-templates #174

merged 1 commit into from
Feb 21, 2019

Conversation

felixrieseberg
Copy link
Member

This fixes show-me templates, this time for real 馃

@coveralls
Copy link

coveralls commented Feb 20, 2019 •
edited

Coverage Status

Coverage remained the same at 98.721% when pulling 23ac9b8 on fix-show-me into 4bf2bee on master.

malept
malept requested changes Feb 20, 2019
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just the IPC folder needs to be lowercased?

@felixrieseberg felixrieseberg force-pushed the fix-show-me branch 2 times, most recently from 83f1e15 to 7ef1df9 Compare February 20, 2019 16:22
@felixrieseberg
Copy link
Member Author

Ugh, git somehow managed to create both an IPC and an ipc folder.

@felixrieseberg
Copy link
Member Author

@malept ...and fixed!

malept
malept approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine now.

@felixrieseberg felixrieseberg merged commit 49538ea into master Feb 21, 2019
@malept malept deleted the fix-show-me branch February 21, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixrieseberg @coveralls @malept