feat(publisher-github): allow to override existing assets

ISSUES CLOSED: #1760
electron · Dec 18, 2020 · 00c419a · 00c419a
1 parent 96cb015
commit 00c419a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/publisher/github/src/Config.ts b/packages/publisher/github/src/Config.ts
@@ -39,4 +39,8 @@ export interface PublisherGitHubConfig {
    * Whether or not this release should be tagged as a draft
    */
   draft?: boolean;
+  /**
+   * Re-upload the new asset if you upload an asset with the same filename as existing asset
+   */
+  override?: boolean;
 }
diff --git a/packages/publisher/github/src/PublisherGithub.ts b/packages/publisher/github/src/PublisherGithub.ts
@@ -108,9 +108,19 @@ export default class PublisherGithub extends PublisherBase<PublisherGitHubConfig
             .replace(/\.$/g, '')
             .replace(/[^\w.-]/g, '-');
           // eslint-disable-next-line max-len
-          if (release!.assets.find((asset: OctokitReleaseAsset) => asset.name === artifactName)) {
-            return done();
+          const asset = release!.assets.find((asset: OctokitReleaseAsset) => item.name === artifactName);
+          if (asset !== undefined) {
+            if (config.override === true) {
+              await github.getGitHub().repos.deleteReleaseAsset({
+                owner: config.repository.owner,
+                repo: config.repository.name,
+                asset_id: asset.id,
+              });
+            } else {
+              return done();
+            }
           }
+
           await github.getGitHub().repos.uploadReleaseAsset({
             owner: config.repository.owner,
             repo: config.repository.name,