fix(package): ensure electron-packager throws if fails (#3136)

electron · Jan 11, 2023 · 4c813a7 · 4c813a7
1 parent 6a118c6
commit 4c813a7
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/packages/api/core/src/api/package.ts b/packages/api/core/src/api/package.ts
@@ -165,11 +165,6 @@ export const listrPackage = ({
 
           task.output = 'Determining targets...';
 
-          let provideTargets: (targets: TargetDefinition[]) => void;
-          const targetsPromise = new Promise<InternalTargetDefinition[]>((resolve) => {
-            provideTargets = resolve;
-          });
-
           type StepDoneSignalMap = Map<string, (() => void)[]>;
           const signalCopyDone: StepDoneSignalMap = new Map();
           const signalRebuildDone: StepDoneSignalMap = new Map();
@@ -186,6 +181,12 @@ export const listrPackage = ({
             });
           };
 
+          let provideTargets: (targets: TargetDefinition[]) => void;
+          const targetsPromise = new Promise<InternalTargetDefinition[]>((resolve, reject) => {
+            provideTargets = resolve;
+            rejects.push(reject);
+          });
+
           const rebuildTasks = new Map<string, Promise<ForgeListrTask<never>>[]>();
           const signalRebuildStart = new Map<string, ((task: ForgeListrTask<never>) => void)[]>();
 
@@ -309,7 +310,9 @@ export const listrPackage = ({
           // rejects is populated by the reject handlers for every
           // signal based promise in every subtask
           ctx.packagerPromise.catch((err) => {
-            for (const reject of rejects) reject(err);
+            for (const reject of rejects) {
+              reject(err);
+            }
           });
 
           const targets = await targetsPromise;