fix: handle missing manifest in zip maker (#3405)

electron · Nov 9, 2023 · b4f6dd9 · b4f6dd9
1 parent fd00d9a
commit b4f6dd9
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/packages/maker/zip/src/MakerZIP.ts b/packages/maker/zip/src/MakerZIP.ts
@@ -48,7 +48,9 @@ export default class MakerZIP extends MakerBase<MakerZIPConfig> {
     if (targetPlatform === 'darwin' && this.config.macUpdateManifestBaseUrl) {
       const parsed = new URL(this.config.macUpdateManifestBaseUrl);
       parsed.pathname += '/RELEASES.json';
-      const response = await got.get(parsed.toString());
+      const response = await got.get(parsed.toString(), {
+        throwHttpErrors: false,
+      });
       let currentValue: SquirrelMacReleases = {
         currentRelease: '',
         releases: [],

diff --git a/packages/maker/zip/test/MakerZip_spec.ts b/packages/maker/zip/test/MakerZip_spec.ts
@@ -143,6 +143,30 @@ describe('MakerZip', () => {
         expect(foo.releases[0].updateTo).to.have.property('url');
       });
 
+      it('should generate a valid RELEASES.json manifest with no current file', async () => {
+        maker.config = {
+          macUpdateManifestBaseUrl: 'fake://test/foo',
+        };
+        getStub.returns(Promise.resolve({ statusCode: 404, body: 'GARBAGE' }));
+        const output = await maker.make({
+          dir: darwinDir,
+          makeDir,
+          appName,
+          targetArch,
+          targetPlatform: 'darwin',
+          packageJSON,
+          forgeConfig: null as any,
+        });
+
+        const foo = await fs.readJson(output[1]);
+        expect(foo).to.have.property('currentRelease', '1.2.3');
+        expect(foo).to.have.property('releases');
+        expect(foo.releases).to.be.an('array').with.lengthOf(1);
+        expect(foo.releases[0]).to.have.property('version');
+        expect(foo.releases[0]).to.have.property('updateTo');
+        expect(foo.releases[0].updateTo).to.have.property('url');
+      });
+
       it('should extend the current RELEASES.json manifest if it exists', async () => {
         maker.config = {
           macUpdateManifestBaseUrl: 'fake://test/foo',