Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Support responding to /sockjs-node/info at webpack dev server #1530

Closed
3 tasks done
MOZGIII opened this issue Mar 1, 2020 · 5 comments
Closed
3 tasks done

[6.x] Support responding to /sockjs-node/info at webpack dev server #1530

MOZGIII opened this issue Mar 1, 2020 · 5 comments

Comments

@MOZGIII
Copy link
Contributor

MOZGIII commented Mar 1, 2020

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

I'm using https://github.com/pmmmwh/react-refresh-webpack-plugin and it sends info requests to show compile-time errors. They fail with 404.

Proposed Solution

Add support for presenting compile-time errors.

Alternatives Considered

I considered disabling the info requests on the client. However, this is

  • not implemented;
  • clearly a worse option.

Additional Information

electron-forge 6 beta 50

@MOZGIII MOZGIII changed the title Support responding to /sockjs-node/info at webpack dev server [6.x] Support responding to /sockjs-node/info at webpack dev server Mar 1, 2020
@malept
Copy link
Member

malept commented Mar 3, 2020

The main thing blocking this is that we're not currently using webpack-dev-server. This is because we're using a custom logger so that we can send webpack output to the stats webserver. In order to fix this without adding a lot of functionality to Electron Forge itself, we would need to refactor to use webpack-dev-server and also be able to redirect console to the stats server, via logger.configureDefaultLogger({..., console}).

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Mar 6, 2020

I think part of the problem is this plugin is loaded in the preload entrypoint. Is there a way to only enable a plugin for render non-preload entry points only?

@malept
Copy link
Member

malept commented Mar 6, 2020

Is there a way to only enable a plugin for render non-preload entry points only?

Not currently. The renderer config is loaded into the associated preload entry point's config.

@simonh1000
Copy link

Another reason for wanting the webpack-dev-server is for its proxying and before capabilities

@malept
Copy link
Member

malept commented May 23, 2021

As of beta 56 the webpack plugin has been refactored to use webpack-dev-server instead of a custom express app.

@malept malept closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants