Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn berry (Yarn 2.x) support #2535

Closed
3 tasks done
TheColdPot opened this issue Sep 20, 2021 · 6 comments
Closed
3 tasks done

Yarn berry (Yarn 2.x) support #2535

TheColdPot opened this issue Sep 20, 2021 · 6 comments

Comments

@TheColdPot
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

When I trying to use yarn berry to run electron forge, it says

PackageNotFoundError: Cannot find the package "electron". Perhaps you need to run "yarn install" in "D:\program\datapack-planet"?

I already run yarn install, it's not work

Proposed solution

Use other ways instead find directory in node_modules to find electron package.

Alternatives considered

run start webpack server and electron directly.

Additional information

No response

@MarshallOfSound
Copy link
Member

Electron itself doesn't support yarn v2 (berry), use the original yarn v1 which works correctly instead of the v2 version which does non standard and unsupported things

@Ivan-Parushev
Copy link

I don't understand why this issue has been closed. Yarn's PnP feature isn't going anywhere anytime soon. It is now one of the best ways to start a new nodejs project. Are there any fundamental technical issues with the support? What needs to be done?

@RoyRao2333
Copy link

I'm getting electron@npm:26.2.1 couldn't be built successfully (exit code 1 when yarn install using Yarn 3.6.3. Maybe this is the same issue as this one?

I'd like to use Yarn Berry instead of Yarn v1 very much. Please fix this.

@naruto00fa
Copy link

At least should put notes in official document Getting Started about creating app with Yarn, you have Yarn scripts, but they don't work with the latest version. It took me a long time to find here.

And forge not support even not plan to support ESModules, these 2 decisions are disappointing.

@erickzhao
Copy link
Member

There's an active PR (#3358) to add ESM forge.config.js support.

@erickzhao
Copy link
Member

Thanks for the suggestion though @naruto00fa, see electron-forge/electron-forge-docs@2e82937 for clarification note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants