New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: esm forge.config.js support #3358
Conversation
Of course, I understand that it is better to (1) update typescript (2) update target to |
I think the failing Windows tests are not related to the changes. |
Related #3129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cant ship code that depends on string templated eval, that's neither safe nor generally good practice
@MarshallOfSound maybe you know how to make quite old typescript to not compile Or if you plan to upgrade typescript and compiled module type it should be pretty easy. |
Make a plain JS file that exports a helper that uses the dynamic import method. Not pretty but better than eval imo |
@MarshallOfSound if dynamic import is in js file it is compiled to require.... I need help to figure it out. return Promise.resolve().then(() => __importStar(require(path))); |
@MarshallOfSound I think I was able to get it to work with the current version of ts. Could you please check the current implementation? |
Windows tests are fixed! |
@MarshallOfSound @erikian @erickzhao what can I do to ship this feature? |
@MarshallOfSound @erikian @erickzhao it is me again 馃槈 What should I do to ship this feature? |
hi, what's the update on this progress? |
Looks like it doesn't work with forge.config. The
|
Summarize your changes:
This tiny PR adds ESM config support. Test added. Closes #3350
It is not a breaking change. Be ready for Electron 28 with ESM support! 馃挴