Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite plugin seems to preserve symlinks during packageAfterCopy hook #3632

Open
3 tasks done
peterekjs opened this issue Jun 19, 2024 · 0 comments · May be fixed by #3633
Open
3 tasks done

Vite plugin seems to preserve symlinks during packageAfterCopy hook #3632

peterekjs opened this issue Jun 19, 2024 · 0 comments · May be fixed by #3633

Comments

@peterekjs
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.4.0

Electron version

31.0.0

Operating system

Ubuntu 20.04

Last known working Electron Forge version

7.2.0

Expected behavior

All dependencies in package node_modules directory are copies and none of them is symlink.

Actual behavior

When using a monorepo setup where some app dependencies are linked into node_modules, these symlinks are copied without being dereferenced.

Steps to reproduce

  1. Use npm workspaces with several npm modules.
  2. Have your app depend on other modules from the same workspace.
  3. Use @electron-forge/plugin-vite in your configuration.
  4. After running electron-forge package, navigate to out/[your package directory]/node_modules and search for modules from your workspace. You will see that these are symlinks, not copies.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant