Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Please add a electron-forge doctor command #94

Closed
deepak opened this issue Jan 20, 2017 · 2 comments
Closed

Request: Please add a electron-forge doctor command #94

deepak opened this issue Jan 20, 2017 · 2 comments
Labels

Comments

@deepak
Copy link

deepak commented Jan 20, 2017

Facing an issue on Windows 10

Not sure of the solution, but i will try re-installing node and elecron-forge later
installing electron-forge again did not solve the issue

I think it wold be a good idea to add a electron-forge doctor command to lint for common issues such as

  • .compilerc file not being present
  • sha of the dependencies is the node_modules folder

Proposal is similar to "brew doctor" command in homebrew

@MarshallOfSound
Copy link
Member

I believe this is out of scope for electron-forge. To verify dependencies you should use your package manager (npm or yarn) and the .compilerc is technically optional. Important to realize the electron-forge is not a package manager.

Happy for someone to override me on this but I believe this is out of scope.

@deepak
Copy link
Author

deepak commented Jan 20, 2017

@MarshallOfSound thanks for answering :-)

maybe a better question to ask is, why this and such a problem can occur ?
not sure

To verify dependencies you should use your package manager (npm or yarn)

How to use npm or yarn for that ?
also can npm protect me against a corrupted .compilerc file or any of the dependencies ?

Important to realize the electron-forge is not a package manager

I only gave homebrew as an example.
I think hombrew provides that option, only because no one else can.
and because their users would be asking why homebrew is not working for them in some weird case
and "homebrew doctor" only raises the most common problems
people still face problems

but agree that the doctor command is essential for hombrew, where third-party packages are being installed. but so much for electron-forge

electron-forge is not a package manager, but it is:

  • compiling packages
  • packaging into an electron app

so some means to checking the dependencies would be nice

also am saying, for me electron-forge is like homebrew
ie. it is my only point of contact about electron
like homebrew, i am interacting only with electron-forge

also, can i can ask npm if:

  • all the dependencies of electron-forge and it dependencies-dependencies etc are correct
  • an optional .compilerc is correct or not
  • etc not even sure what other checks are there

so am suggesting that electron-forge must have that check
maybe electron-forge and its chain of dependencies all must have a "doctor" script.

such a check would be nice, not sure who or even if it should be provided

if that is out of scope, maybe an electron-forge test command
which has a sample electron app, and test cases which can be run against it

dsanders11 pushed a commit that referenced this issue Jan 14, 2023
fix: Adjust gist link address bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants