Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): show warning when a user supplies an unknown subcommand #1301

Closed

Conversation

jamesgeorge007
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
closes #1300

@codecov
Copy link

codecov bot commented Nov 24, 2019

Codecov Report

Merging #1301 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   68.43%   68.13%   -0.31%     
==========================================
  Files          67       67              
  Lines        1958     1958              
  Branches      378      378              
==========================================
- Hits         1340     1334       -6     
- Misses        444      451       +7     
+ Partials      174      173       -1
Impacted Files Coverage Δ
packages/maker/flatpak/src/MakerFlatpak.ts 72.72% <0%> (-9.1%) ⬇️
packages/maker/appx/src/MakerAppX.ts 45.61% <0%> (-7.02%) ⬇️
packages/utils/async-ora/src/ora.ts 56.66% <0%> (-3.34%) ⬇️
packages/api/core/src/util/rebuild.ts 93.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92817f4...b56e234. Read the comment docs.

@malept malept changed the title feat(cli): show warning on supplying unknown commands fix(cli): show warning when a user supplies an unknown subcommand Nov 26, 2019
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this does not seem to be working with existing commands. Example:

$ electron-forge lint
✔ Checking your system
Usage: electron-forge [options] [command] <command>

Options:
  -V, --version  output the version number
  --verbose      Enables verbose mode
  -h, --help     output usage information

Commands:
  init           Initialize a new Electron application
  import         Attempts to navigate you through the process of importing an existing project to
                 "electron-forge"
  lint           Lints the current Electron application
  package        Package the current Electron application
  make           Generate distributables for the current Electron application
  start          Start the current Electron application
  publish        Publish the current Electron application to GitHub
  install        Install an Electron application from GitHub
  help [cmd]     display help for [cmd]
 Unknown command lint

✔ Linting Application

@malept malept mentioned this pull request Nov 27, 2019
4 tasks
@malept malept closed this in #1304 Nov 27, 2019
@jamesgeorge007 jamesgeorge007 deleted the feat/warn-for-unknown-cmd branch November 27, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn the user on supplying unknown commands
2 participants