New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove rebuild tests that duplicate electron-rebuild #1303

Merged

malept merged 1 commit into electron:master from malept:remove-rebuild-tests

Nov 26, 2019

Member

malept commented Nov 26, 2019

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project follows, as appropriate.
The changes have sufficient test coverage (if applicable).
The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Equivalent tests in electron-rebuild

Removing these tests shaves off 1-2 minutes from each testsuite run.


          test: remove rebuild tests that duplicate electron-rebuild

b19d79c

malept merged commit 92817f4 into electron:master

malept deleted the remove-rebuild-tests branch

November 26, 2019 02:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment