Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create base template & test utils #1351

Merged
merged 22 commits into from
Dec 17, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 17, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

DRYs up the template code with a base template class (and new module @electron-forge/template-base). The template tests were also moved to their respective modules. As a result of that, a new module for test utility functions (@electron-forge/test-utils) needed to be created as well.

@malept malept mentioned this pull request Dec 17, 2019
5 tasks
@malept malept merged commit 3e5a64c into electron:master Dec 17, 2019
@malept malept deleted the refactor-templates branch December 17, 2019 22:18
@malept malept mentioned this pull request Jan 9, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant