Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-webpack): remove async=false option from ts-checker to avoid preload compile hang #1497

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 18, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1386.

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #1497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1497   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files          73       73           
  Lines        2135     2135           
  Branches      398      398           
=======================================
  Hits         1603     1603           
  Misses        408      408           
  Partials      124      124
Impacted Files Coverage Δ
packages/maker/flatpak/src/MakerFlatpak.ts 86.95% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d015bab...fdc176c. Read the comment docs.

@malept malept merged commit fe5b33c into master Feb 18, 2020
@malept malept deleted the fix-preload-fork-ts-checker-hanging branch February 18, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[typescript-webpack] compiling preload hangs
1 participant