-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(publisher-github): remove octokit deprecation warnings #1673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! I take it you've tested these changes manually?
All that's needed at this point is to fix the tests, which are unfortunately kind of fragile due to the module needing to access the network normally.
- Update these tests to reflect how the user agent is now specified:
https://github.com/electron-userland/electron-forge/blob/1cfe04989c0976a1317c4b91c6467f7986ddda68/packages/publisher/github/test/github_spec.ts#L61-L63
- It looks like the following tests need to be rewritten to not use mocks:
They'll probably look closer to the user agent tests.
@b-zurg could you please update the tests to have changes merged? |
I'll take care of it tomorrow. Sorry it's taken me so long to finish this up. |
I've made some of the necessary changes. I did a bit of investigation and it doesn't seem like an authenticate is necessary anymore for the GitHub class as all it did was set I've had a lot of trouble getting bolt and tests running well, the dev cycle is very slow because of the extensive amount of tests, however I hope to get them running soon on my local env. This PR is not ready for merge yet. |
For your purposes, you should be able to filter out most tests, by running: yarn test --glob=test/github_spec.ts It's something I need to add to |
Summarize your changes:
Implemented API Changes in order to remove deprecation warnings from github publisher.
Closes #1672