fix(plugin-webpack): prevent the renderer config from overriding its preload config's target

[vazra]

override preload script webpack target to electron-preload

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
while merging to create a Webpack config for preload script, made the target from the renderer config ignored and manually set to electron-preload

Fixes #1852

[vazra]

any better ways to fix this? @malept @MarshallOfSound

[malept]

This seems OK, although I don't know if there are legitimate use cases to override the preload's target.

Can you add a test for this in packages/plugin/webpack/test/WebpackConfig_spec.ts?

[vazra]

Can you add a test for this in packages/plugin/webpack/test/WebpackConfig_spec.ts?

sure, will do. 👍

[vazra]

Can you add a test for this in packages/plugin/webpack/test/WebpackConfig_spec.ts?

@malept, added some tests, please have a look.

[malept]

This seems fine, but I have suggestions for making the new tests smaller.

[codecov]

Codecov Report

Merging #1853 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1853   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          74       74           
  Lines        2210     2210           
  Branches      416      416           
=======================================
  Hits         1607     1607           
  Misses        443      443           
  Partials      160      160           

Impacted Files	Coverage Δ
packages/plugin/webpack/src/WebpackConfig.ts	95.23% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ca86a...6f022a2. Read the comment docs.